wires/hypnagaga_old
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove extraneous aria-labels on theme buttons

Browse source
This commit is contained in:
Jean Ducrot 2024-08-13 23:14:56 -04:00 committed by GitHub
parent f7bc03e8af
commit 03c91b97f2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/assets/scripts/bundle/theme-toggle.js
View file

@ -60,8 +60,11 @@ function setPreference() {
function reflectPreference() { function reflectPreference() {
document.firstElementChild.setAttribute('data-theme', theme.value); document.firstElementChild.setAttribute('data-theme', theme.value);
document.querySelector('#light-theme-toggle')?.setAttribute('aria-label', lightLabel); // Let the button content set its accessible name. There is no need for an aria-label on a button with visible text.
document.querySelector('#dark-theme-toggle')?.setAttribute('aria-label', darkLabel); // This practice can become a problem when the page is translated by the browser as often aria-labels are left alone
// this code would override the translated language and confuse the user
// document.querySelector('#light-theme-toggle')?.setAttribute('aria-label', lightLabel);
// document.querySelector('#dark-theme-toggle')?.setAttribute('aria-label', darkLabel);
} }
function updateMetaThemeColor() { function updateMetaThemeColor() {