From d6240e249739071270ab660557ea314e7447305c Mon Sep 17 00:00:00 2001 From: Jon McClure Date: Mon, 24 Jul 2023 22:25:39 +0100 Subject: [PATCH] better scss token convention --- .storybook/preview.scss | 10 +- src/components/Headline/Headline.svelte | 2 +- src/docs/styles/typography/main.stories.mdx | 20 +-- src/docs/styles/typography/styles.scss | 3 - src/scss/_mixins.scss | 6 - src/scss/_variables.scss | 2 - src/scss/components/_hero-title.scss | 118 -------------- src/scss/extenders.scss | 2 + src/scss/fonts/_font-faces.scss | 84 +++++----- src/scss/fonts/_mixins.scss | 25 --- src/scss/fonts/_rules.scss | 19 --- src/scss/fonts/_variables.scss | 26 --- src/scss/main.scss | 5 +- src/scss/text/_font-faces.scss | 117 -------------- src/scss/tokens.scss | 3 +- src/scss/{ => tokens}/spacers/_main.scss | 0 src/scss/tokens/spacers/_margin.scss | 66 ++++++++ src/scss/tokens/spacers/_padding.scss | 47 ++++++ src/scss/tokens/spacers/extenders/_main.scss | 2 + .../spacers/extenders}/_margin.scss | 42 ++--- .../spacers/extenders}/_padding.scss | 30 ++-- src/scss/{ => tokens}/text/_font-family.scss | 2 +- src/scss/{ => tokens}/text/_font-size.scss | 2 +- src/scss/{ => tokens}/text/_font-style.scss | 2 +- src/scss/{ => tokens}/text/_font-weight.scss | 2 +- .../{ => tokens}/text/_letter-spacing.scss | 2 +- src/scss/{ => tokens}/text/_line-height.scss | 2 +- .../{text/tokens => tokens/text}/_main.scss | 0 src/scss/{ => tokens}/text/_text-align.scss | 2 +- .../{ => tokens}/text/_text-decoration.scss | 2 +- .../{ => tokens}/text/_text-transform.scss | 2 +- .../{ => tokens}/text/_vertical-align.scss | 2 +- src/scss/{ => tokens}/text/_white-space.scss | 2 +- src/scss/{ => tokens}/text/_word-break.scss | 2 +- .../text/extenders}/_font-family.scss | 0 .../text/extenders}/_font-size.scss | 0 .../text/extenders}/_font-style.scss | 0 .../text/extenders}/_font-weight.scss | 0 .../text/extenders}/_letter-spacing.scss | 0 .../text/extenders}/_line-height.scss | 0 .../text/extenders}/_main.scss | 1 - .../text/extenders}/_text-align.scss | 0 .../text/extenders}/_text-decoration.scss | 0 .../text/extenders}/_text-transform.scss | 0 .../text/extenders}/_vertical-align.scss | 0 .../text/extenders}/_white-space.scss | 0 .../text/extenders}/_word-break.scss | 0 src/scss/typography/_font-faces.scss | 117 -------------- src/scss/typography/_main.scss | 14 -- src/scss/typography/_mixins.scss | 125 --------------- src/scss/typography/_rules.scss | 150 ------------------ src/scss/typography_old/_box-shadow.scss | 11 -- src/scss/typography_old/_font-size.scss | 81 ---------- src/scss/typography_old/_letter-spacing.scss | 15 -- src/scss/typography_old/_main.scss | 5 - src/scss/typography_old/_mixins.scss | 47 ------ src/scss/typography_old/_rules.scss | 82 ---------- src/scss/typography_old/_text-shadow.scss | 13 -- src/scss/typography_old/_transform.scss | 7 - src/scss/typography_old/_variables.scss | 39 ----- 60 files changed, 221 insertions(+), 1139 deletions(-) delete mode 100644 src/scss/_mixins.scss delete mode 100644 src/scss/_variables.scss delete mode 100644 src/scss/components/_hero-title.scss create mode 100644 src/scss/extenders.scss delete mode 100644 src/scss/fonts/_mixins.scss delete mode 100644 src/scss/fonts/_rules.scss delete mode 100644 src/scss/fonts/_variables.scss delete mode 100644 src/scss/text/_font-faces.scss rename src/scss/{ => tokens}/spacers/_main.scss (100%) create mode 100644 src/scss/tokens/spacers/_margin.scss create mode 100644 src/scss/tokens/spacers/_padding.scss create mode 100644 src/scss/tokens/spacers/extenders/_main.scss rename src/scss/{spacers => tokens/spacers/extenders}/_margin.scss (75%) rename src/scss/{spacers => tokens/spacers/extenders}/_padding.scss (74%) rename src/scss/{ => tokens}/text/_font-family.scss (87%) rename src/scss/{ => tokens}/text/_font-size.scss (96%) rename src/scss/{ => tokens}/text/_font-style.scss (83%) rename src/scss/{ => tokens}/text/_font-weight.scss (96%) rename src/scss/{ => tokens}/text/_letter-spacing.scss (94%) rename src/scss/{ => tokens}/text/_line-height.scss (95%) rename src/scss/{text/tokens => tokens/text}/_main.scss (100%) rename src/scss/{ => tokens}/text/_text-align.scss (94%) rename src/scss/{ => tokens}/text/_text-decoration.scss (90%) rename src/scss/{ => tokens}/text/_text-transform.scss (82%) rename src/scss/{ => tokens}/text/_vertical-align.scss (95%) rename src/scss/{ => tokens}/text/_white-space.scss (88%) rename src/scss/{ => tokens}/text/_word-break.scss (85%) rename src/scss/{text/tokens => tokens/text/extenders}/_font-family.scss (100%) rename src/scss/{text/tokens => tokens/text/extenders}/_font-size.scss (100%) rename src/scss/{text/tokens => tokens/text/extenders}/_font-style.scss (100%) rename src/scss/{text/tokens => tokens/text/extenders}/_font-weight.scss (100%) rename src/scss/{text/tokens => tokens/text/extenders}/_letter-spacing.scss (100%) rename src/scss/{text/tokens => tokens/text/extenders}/_line-height.scss (100%) rename src/scss/{text => tokens/text/extenders}/_main.scss (92%) rename src/scss/{text/tokens => tokens/text/extenders}/_text-align.scss (100%) rename src/scss/{text/tokens => tokens/text/extenders}/_text-decoration.scss (100%) rename src/scss/{text/tokens => tokens/text/extenders}/_text-transform.scss (100%) rename src/scss/{text/tokens => tokens/text/extenders}/_vertical-align.scss (100%) rename src/scss/{text/tokens => tokens/text/extenders}/_white-space.scss (100%) rename src/scss/{text/tokens => tokens/text/extenders}/_word-break.scss (100%) delete mode 100644 src/scss/typography/_font-faces.scss delete mode 100644 src/scss/typography/_main.scss delete mode 100644 src/scss/typography/_mixins.scss delete mode 100644 src/scss/typography/_rules.scss delete mode 100644 src/scss/typography_old/_box-shadow.scss delete mode 100644 src/scss/typography_old/_font-size.scss delete mode 100644 src/scss/typography_old/_letter-spacing.scss delete mode 100644 src/scss/typography_old/_main.scss delete mode 100644 src/scss/typography_old/_mixins.scss delete mode 100644 src/scss/typography_old/_rules.scss delete mode 100644 src/scss/typography_old/_text-shadow.scss delete mode 100644 src/scss/typography_old/_transform.scss delete mode 100644 src/scss/typography_old/_variables.scss diff --git a/.storybook/preview.scss b/.storybook/preview.scss index 3dc7f82b..267cf6da 100644 --- a/.storybook/preview.scss +++ b/.storybook/preview.scss @@ -1,5 +1,3 @@ -@import "../src/scss/mixins"; - table.docblock-argstable { p { font-family: inherit; @@ -39,16 +37,16 @@ div.sbdocs-content { } .sbdocs { - @include font-display; + font-family: 'Knowledge', sans-serif; h1 { - @include font-display; + font-family: 'Knowledge', sans-serif; } p, ul, li { font-size: 18px; line-height: 29px; - @include font-display; + font-family: 'Knowledge', sans-serif; .highlight { background-color: rgb(254, 254, 160); @@ -60,7 +58,7 @@ div.sbdocs-content { } a { - @include font-display; + font-family: 'Knowledge', sans-serif; color: #0071a1; text-decoration: none; text-underline-offset: 2px; diff --git a/src/components/Headline/Headline.svelte b/src/components/Headline/Headline.svelte index 3fdcadae..c73e8e82 100644 --- a/src/components/Headline/Headline.svelte +++ b/src/components/Headline/Headline.svelte @@ -69,7 +69,7 @@