From 44f3d6407012f220a3f52a86805a54ebef82841c Mon Sep 17 00:00:00 2001 From: Sudev Kiyada Date: Tue, 22 Apr 2025 22:39:26 +0530 Subject: [PATCH 01/25] expose bindable props --- .../Scroller/Scroller.stories.svelte | 18 ++++++++++++++++++ src/components/Scroller/Scroller.svelte | 14 +++++++++----- 2 files changed, 27 insertions(+), 5 deletions(-) diff --git a/src/components/Scroller/Scroller.stories.svelte b/src/components/Scroller/Scroller.stories.svelte index 101b4967..ca233b30 100644 --- a/src/components/Scroller/Scroller.stories.svelte +++ b/src/components/Scroller/Scroller.stories.svelte @@ -19,6 +19,24 @@ control: 'select', options: ['fb', 'bf'], }, + index: { + control: false, + table: { + category: 'Bindable states (Read-only)', + }, + }, + offset: { + control: false, + table: { + category: 'Bindable states (Read-only)', + }, + }, + progress: { + control: false, + table: { + category: 'Bindable states (Read-only)', + }, + }, }, }); diff --git a/src/components/Scroller/Scroller.svelte b/src/components/Scroller/Scroller.svelte index 777cef59..b6c897b2 100644 --- a/src/components/Scroller/Scroller.svelte +++ b/src/components/Scroller/Scroller.svelte @@ -74,6 +74,12 @@ id?: string; /** Set a class to target with SCSS */ class?: string; + /** The currently active section */ + index?: number; + /** How far the section has scrolled past the threshold, as a value between 0 and 1 */ + offset?: number; + /** How far the foreground has travelled, where 0 is the top of the foreground crossing top, and 1 is the bottom crossing bottom */ + progress?: number; } let { @@ -90,12 +96,10 @@ bottom = 1, parallax = false, class: cls = '', + index = $bindable(0), + offset = $bindable(0), + progress = $bindable(0), }: Props = $props(); - - // Bindable variables passed to ScrollerBase - let index = $state(0); - let offset = $state(0); - let progress = $state(0); {#if !embedded} From 28a2c2663438f302613df0a1980e9a0687a51e42 Mon Sep 17 00:00:00 2001 From: Sudev Kiyada Date: Tue, 22 Apr 2025 22:40:00 +0530 Subject: [PATCH 02/25] Create lefthook.yml --- lefthook.yml | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 lefthook.yml diff --git a/lefthook.yml b/lefthook.yml new file mode 100644 index 00000000..3ac5730a --- /dev/null +++ b/lefthook.yml @@ -0,0 +1,42 @@ +# EXAMPLE USAGE: +# +# Refer for explanation to following link: +# https://lefthook.dev/configuration/ +# +# pre-push: +# jobs: +# - name: packages audit +# tags: +# - frontend +# - security +# run: yarn audit +# +# - name: gems audit +# tags: +# - backend +# - security +# run: bundle audit +# +# pre-commit: +# parallel: true +# jobs: +# - run: yarn eslint {staged_files} +# glob: "*.{js,ts,jsx,tsx}" +# +# - name: rubocop +# glob: "*.rb" +# exclude: +# - config/application.rb +# - config/routes.rb +# run: bundle exec rubocop --force-exclusion {all_files} +# +# - name: govet +# files: git ls-files -m +# glob: "*.go" +# run: go vet {files} +# +# - script: "hello.js" +# runner: node +# +# - script: "hello.go" +# runner: go run From 4b52ad8cdc734069cfcc4d817c266f85fcffb842 Mon Sep 17 00:00:00 2001 From: Sudev Kiyada Date: Tue, 22 Apr 2025 22:49:53 +0530 Subject: [PATCH 03/25] Delete lefthook.yml --- lefthook.yml | 42 ------------------------------------------ 1 file changed, 42 deletions(-) delete mode 100644 lefthook.yml diff --git a/lefthook.yml b/lefthook.yml deleted file mode 100644 index 3ac5730a..00000000 --- a/lefthook.yml +++ /dev/null @@ -1,42 +0,0 @@ -# EXAMPLE USAGE: -# -# Refer for explanation to following link: -# https://lefthook.dev/configuration/ -# -# pre-push: -# jobs: -# - name: packages audit -# tags: -# - frontend -# - security -# run: yarn audit -# -# - name: gems audit -# tags: -# - backend -# - security -# run: bundle audit -# -# pre-commit: -# parallel: true -# jobs: -# - run: yarn eslint {staged_files} -# glob: "*.{js,ts,jsx,tsx}" -# -# - name: rubocop -# glob: "*.rb" -# exclude: -# - config/application.rb -# - config/routes.rb -# run: bundle exec rubocop --force-exclusion {all_files} -# -# - name: govet -# files: git ls-files -m -# glob: "*.go" -# run: go vet {files} -# -# - script: "hello.js" -# runner: node -# -# - script: "hello.go" -# runner: go run From 93a41f32aa1221f09d0970b0a10215fff4ccb8eb Mon Sep 17 00:00:00 2001 From: Sudev Kiyada Date: Tue, 22 Apr 2025 22:58:21 +0530 Subject: [PATCH 04/25] docs(changeset): Exposes bindable props for the Scroller component --- .changeset/huge-moles-watch.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/huge-moles-watch.md diff --git a/.changeset/huge-moles-watch.md b/.changeset/huge-moles-watch.md new file mode 100644 index 00000000..ebe5dcc8 --- /dev/null +++ b/.changeset/huge-moles-watch.md @@ -0,0 +1,5 @@ +--- +'@reuters-graphics/graphics-components': patch +--- + +Exposes bindable props for the Scroller component From 185039c35e87d1d08fe8bbe9dc40a29a28591d3f Mon Sep 17 00:00:00 2001 From: MinamiFunakoshiTR Date: Tue, 22 Apr 2025 15:23:18 -0400 Subject: [PATCH 05/25] fix rngs.io keys for site headline --- src/components/SiteHeadline/SiteHeadline.mdx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/SiteHeadline/SiteHeadline.mdx b/src/components/SiteHeadline/SiteHeadline.mdx index 3bb36dc4..5812a57e 100644 --- a/src/components/SiteHeadline/SiteHeadline.mdx +++ b/src/components/SiteHeadline/SiteHeadline.mdx @@ -58,8 +58,8 @@ updated: sectionUrl={content.sectionUrl} hed={content.hed} authors={content.authors.split(',')} - publishTime={content.published} - updateTime={content.updated} + publishTime={content.publishTime} + updateTime={content.updatTime} /> ``` From 074c4884659aad7ffd3483d961d66990afb38a0e Mon Sep 17 00:00:00 2001 From: MinamiFunakoshiTR Date: Tue, 22 Apr 2025 15:23:37 -0400 Subject: [PATCH 06/25] fix typo in timeline docs --- src/components/SimpleTimeline/SimpleTimeline.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/SimpleTimeline/SimpleTimeline.mdx b/src/components/SimpleTimeline/SimpleTimeline.mdx index 7ff74758..2747ad25 100644 --- a/src/components/SimpleTimeline/SimpleTimeline.mdx +++ b/src/components/SimpleTimeline/SimpleTimeline.mdx @@ -72,7 +72,7 @@ titleLink: https://www.reuters.com/world/us-house-vote-40-billion-ukraine-aid-pa import content from '$locales/en/content.json'; - + ``` From fd7a496888acd004b9965f0e5f9dc7b1f97639c3 Mon Sep 17 00:00:00 2001 From: MinamiFunakoshiTR Date: Tue, 22 Apr 2025 15:34:57 -0400 Subject: [PATCH 07/25] fixes timeline archieml docs; --- .../SimpleTimeline/SimpleTimeline.mdx | 40 ++++++++++--------- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/src/components/SimpleTimeline/SimpleTimeline.mdx b/src/components/SimpleTimeline/SimpleTimeline.mdx index 2747ad25..7eb4c72b 100644 --- a/src/components/SimpleTimeline/SimpleTimeline.mdx +++ b/src/components/SimpleTimeline/SimpleTimeline.mdx @@ -40,24 +40,20 @@ With the graphics kit, you'll likely get your text value from an ArchieML doc. ```yaml # Archie ML doc -[timeline] - -# date object with events -date: May 18 -[.events] -title: Mariupol defenders surrender to Russia but their fate is uncertain -context: More than 250 Ukrainian fighters surrendered to Russian forces at the Azovstal steelworks in Mariupol after weeks of desperate resistance, bringing an end to the most devastating siege of Russia's war in Ukraine and allowing President Vladimir Putin to claim a rare victory in his faltering campaign. -titleLink: https://www.reuters.com/world/europe/ukrainian-troops-evacuate-mariupol-ceding-control-russia-2022-05-17/ - -# More events... -[] - -date: May 10 -[.events] -title: U.S. House passes $40 bln bill to bolster Ukraine against Russian invasion -context: The U.S. House of Representatives approved more than $40 billion more aid for Ukraine on Tuesday, as Congress races to keep military aid flowing and boost the government in Kyiv as it grapples with the Russian invasion. -titleLink: https://www.reuters.com/world/us-house-vote-40-billion-ukraine-aid-package-tuesday-pelosi-2022-05-10/ -[] +type: timeline +# Optional +class: timeline +id: timeline-1 +symbolColour: var(--theme-colour-brand-rules, grey) +dateColour: var(--theme-colour-accent, red) +[.dates] + # date object with events + date: May 10 + [.events] + title: U.S. House passes $40 bln bill to bolster Ukraine against Russian invasion + context: The U.S. House of Representatives approved more than $40 billion more aid for Ukraine on Tuesday, as Congress races to keep military aid flowing and boost the government in Kyiv as it grapples with the Russian invasion. + titleLink: https://www.reuters.com/world/us-house-vote-40-billion-ukraine-aid-package-tuesday-pelosi-2022-05-10/ + [] # More dates and events... [] @@ -72,7 +68,13 @@ titleLink: https://www.reuters.com/world/us-house-vote-40-billion-ukraine-aid-pa import content from '$locales/en/content.json'; - + ``` From 3eb666f1b8a5e424f306de7e3ad81584123ab9f3 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue, 22 Apr 2025 20:18:41 +0000 Subject: [PATCH 08/25] RELEASING: Releasing 1 package(s) Releases: @reuters-graphics/graphics-components@3.0.1 [skip ci] --- .changeset/huge-moles-watch.md | 5 ----- CHANGELOG.md | 6 ++++++ package.json | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) delete mode 100644 .changeset/huge-moles-watch.md diff --git a/.changeset/huge-moles-watch.md b/.changeset/huge-moles-watch.md deleted file mode 100644 index ebe5dcc8..00000000 --- a/.changeset/huge-moles-watch.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@reuters-graphics/graphics-components': patch ---- - -Exposes bindable props for the Scroller component diff --git a/CHANGELOG.md b/CHANGELOG.md index 75e6de88..01f2638a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # @reuters-graphics/graphics-components +## 3.0.1 + +### Patch Changes + +- 93a41f3: Exposes bindable props for the Scroller component + ## 3.0.0 ### Major Changes diff --git a/package.json b/package.json index c2d27323..66c96f67 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@reuters-graphics/graphics-components", - "version": "3.0.0", + "version": "3.0.1", "type": "module", "private": false, "homepage": "https://reuters-graphics.github.io/graphics-components", From e95a5f2b3901a09eeb255171e577f7722b8acc98 Mon Sep 17 00:00:00 2001 From: hobbes7878 Date: Wed, 23 Apr 2025 16:51:38 +0100 Subject: [PATCH 09/25] handles some a11y arias in sitefooter and siteheader we always get dinged on --- src/components/SiteFooter/CompanyLinks.svelte | 10 +++++++++- src/components/SiteHeader/MobileMenu/index.svelte | 6 +++++- .../SiteHeader/NavBar/NavDropdown/index.svelte | 4 ++-- src/components/SiteHeader/NavBar/index.svelte | 2 +- 4 files changed, 17 insertions(+), 5 deletions(-) diff --git a/src/components/SiteFooter/CompanyLinks.svelte b/src/components/SiteFooter/CompanyLinks.svelte index 443dc930..be3c6f29 100644 --- a/src/components/SiteFooter/CompanyLinks.svelte +++ b/src/components/SiteFooter/CompanyLinks.svelte @@ -25,6 +25,11 @@ } let { links = {} }: Props = $props(); + + const normaliseSocialName = (name: string) => { + if (name === 'twitter') return 'X'; + return name; + }; {#if links.social_links} @@ -42,7 +47,10 @@ {@const SvelteComponent = symbols[link.type as keyof typeof symbols]}