diff --git a/src/components/AdSlot/AdSlot.stories.svelte b/src/components/AdSlot/AdSlot.stories.svelte
index ee8bc9aa..a598662f 100644
--- a/src/components/AdSlot/AdSlot.stories.svelte
+++ b/src/components/AdSlot/AdSlot.stories.svelte
@@ -36,7 +36,7 @@
-
+
{
freestar.newAdSlots(freestar.config.enabled_slots);
};
+ // Ask Rachel
freestar.config.channel = '/4735792/reuters.com/home';
- trackTiming('onetrust_start');
-
(window).initBootstrap(
{
onetrust_logs: getParameterByName(ONETRUST_LOGS) || 'false',
@@ -29,33 +27,11 @@ export default () => {
onetrust_script_id: ONETRUST_SCRIPT_ID,
},
(onetrustResponse) => {
- trackTiming('onetrust_completion');
- // Never used...
- // const {
- // require_consent, // eslint-disable-line camelcase
- // consent,
- // require_gdpr_consent, // eslint-disable-line camelcase
- // gdpr_consent_data, // eslint-disable-line camelcase
- // require_ccpa_consent, // eslint-disable-line camelcase
- // ccpa_consent_data, // eslint-disable-line camelcase
- // } = onetrustResponse;
-
- // Trigger data layer events to GTM
- (window).dataLayer = (window).dataLayer || [];
- (window).dataLayer.push({
- event: 'bootstrap_results',
- ...onetrustResponse,
- });
-
- // Never used...
- // const opt_in = require_consent ? consent : true; // eslint-disable-line camelcase
- // const token =
- // (require_gdpr_consent ? gdpr_consent_data : undefined) || // eslint-disable-line camelcase
- // (require_ccpa_consent ? ccpa_consent_data : undefined); // eslint-disable-line camelcase
- // const consent_given = require_consent && consent; // eslint-disable-line camelcase
-
const iasPromise = Ias();
+ // Ask Thea about Permutive implementation (considering there are no logged in users on Graphics)
+ // Should we use Permutive at all?
+ // Should we import ArcP SDK to graphics to get the same user as logged in on RCom?
return Promise.all([iasPromise]).then((responses) => {
const [iasResponse] = responses;
@@ -81,6 +57,7 @@ export default () => {
(window).googletag.pubads().setTargeting('adstest', adstest);
}
+ // Ask Rachel about targeting
const template = (document.querySelector('meta[name="ad:template"]'))?.content;
if (template) {
(window).googletag.pubads().setTargeting('template', template);
diff --git a/src/components/AdSlot/scripts/ias.ts b/src/components/AdSlot/scripts/ias.ts
index 49fc0d1b..16abf1a0 100644
--- a/src/components/AdSlot/scripts/ias.ts
+++ b/src/components/AdSlot/scripts/ias.ts
@@ -1,21 +1,16 @@
-import trackTiming from './trackTiming';
-
const IAS_REQUEST_TIMEOUT = 600;
export default () => {
return new Promise((resolve) => {
- trackTiming('ias_start');
const timerId = setTimeout(() => {
- trackTiming('ias_completion_with_timeout');
resolve('Resolved with timeout');
}, IAS_REQUEST_TIMEOUT);
const setupIAS = () => {
clearTimeout(timerId);
- trackTiming('ias_completion');
(window).__iasPET = (window).__iasPET || {};
(window).__iasPET.queue = (window).__iasPET.queue || [];
- (window).__iasPET.pubId = '931336';
+ (window).__iasPET.pubId = '931336'; // Ask Rachel
resolve('loaded');
};
diff --git a/src/components/AdSlot/scripts/trackTiming.ts b/src/components/AdSlot/scripts/trackTiming.ts
deleted file mode 100644
index 3071eaf5..00000000
--- a/src/components/AdSlot/scripts/trackTiming.ts
+++ /dev/null
@@ -1,9 +0,0 @@
-export default (timingName: string) => {
- const timestamp = window.performance.now();
- (window).dataLayer = (window).dataLayer || [];
- (window).dataLayer.push({
- event: 'rum_add_timing',
- rum_timing_name: timingName,
- rum_timing_timestamp: timestamp,
- });
-};