From 0b83cb5113c91e8ea93db3046a9915b85cfa5f38 Mon Sep 17 00:00:00 2001 From: Ben Aultowski Date: Fri, 27 Feb 2026 15:44:49 -0500 Subject: [PATCH] Lottie.stories.svelte uses #snippet template(args) instead of #snippet children(args). Scroll.stories.svelte (and descendents) use asChild. --- .vscode/settings.json | 3 ++- package.json | 3 ++- packages/graphics-components/package.json | 4 ++-- .../HorizontalScroller.stories.svelte | 14 ++++++------- .../components/Lottie/Lottie.stories.svelte | 20 +++++++++++-------- .../ScrollerVideo.stories.svelte | 16 ++++++++------- pnpm-lock.yaml | 18 ++++++++--------- 7 files changed, 43 insertions(+), 35 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index 523203d..bb39680 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -21,5 +21,6 @@ "liveshare.launcherClient": "visualStudioCode", "[svelte]": { "editor.defaultFormatter": "svelte.svelte-vscode" - } + }, + "fossil.ignoreMissingFossilWarning": true } diff --git a/package.json b/package.json index 3cb9a03..3a538bd 100644 --- a/package.json +++ b/package.json @@ -5,7 +5,8 @@ "private": true, "scripts": { "start": "vite dev --open", - "dev:components": "pnpm --filter @reuters-graphics/graphics-components exec svelte-package --watch", + "dev:components": "pnpm --filter @reuters-graphics/graphics-components exec svelte-package -i ./src --watch", + "storybook": "pnpm --filter @reuters-graphics/graphics-components run start", "build": "vite build", "build:preview": "PREVIEW=true vite build", "mods": "tsx ./bin/mods/index.ts mods", diff --git a/packages/graphics-components/package.json b/packages/graphics-components/package.json index 8b01871..ea15667 100644 --- a/packages/graphics-components/package.json +++ b/packages/graphics-components/package.json @@ -54,7 +54,7 @@ "@storybook/addon-a11y": "^8.6.12", "@storybook/addon-essentials": "^8.6.12", "@storybook/addon-interactions": "^8.6.12", - "@storybook/addon-svelte-csf": "5.0.0-next.28", + "@storybook/addon-svelte-csf": "5.0.11", "@storybook/blocks": "^8.6.12", "@storybook/components": "^8.6.12", "@storybook/manager-api": "^8.6.12", @@ -140,4 +140,4 @@ "bugs": { "url": "https://github.com/reuters-graphics/graphics-components/issues" } -} +} \ No newline at end of file diff --git a/packages/graphics-components/src/components/HorizontalScroller/HorizontalScroller.stories.svelte b/packages/graphics-components/src/components/HorizontalScroller/HorizontalScroller.stories.svelte index c17dfbf..8fcd6a4 100644 --- a/packages/graphics-components/src/components/HorizontalScroller/HorizontalScroller.stories.svelte +++ b/packages/graphics-components/src/components/HorizontalScroller/HorizontalScroller.stories.svelte @@ -26,13 +26,13 @@ - + - + - + - + - + - + - + diff --git a/packages/graphics-components/src/components/Lottie/Lottie.stories.svelte b/packages/graphics-components/src/components/Lottie/Lottie.stories.svelte index 8ecc7da..ab26eeb 100644 --- a/packages/graphics-components/src/components/Lottie/Lottie.stories.svelte +++ b/packages/graphics-components/src/components/Lottie/Lottie.stories.svelte @@ -41,8 +41,9 @@ - {#snippet children(args)} - + {#snippet template(args)} + {@const { src: _src, ...restArgs } = args} + {/snippet} @@ -56,8 +57,9 @@ speed: 0.5, }} > - {#snippet children(args)} - + {#snippet template(args)} + {@const { src: _src, ...restArgs } = args} + {/snippet} @@ -71,20 +73,22 @@ mode: 'bounce', }} > - {#snippet children(args)} - + {#snippet template(args)} + {@const { src: _src, ...restArgs } = args} + {/snippet} - {#snippet children(args)} + {#snippet template(args)} + {@const { src: _src, ...restArgs } = args} {/snippet} diff --git a/packages/graphics-components/src/components/ScrollerVideo/ScrollerVideo.stories.svelte b/packages/graphics-components/src/components/ScrollerVideo/ScrollerVideo.stories.svelte index 94d9a1e..73009fd 100644 --- a/packages/graphics-components/src/components/ScrollerVideo/ScrollerVideo.stories.svelte +++ b/packages/graphics-components/src/components/ScrollerVideo/ScrollerVideo.stories.svelte @@ -144,17 +144,17 @@ - + - + - + {#if width < 600} {:else if width < 1200} @@ -164,15 +164,16 @@ {/if} - + - + - + - + diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index c440bce..561e9e7 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -242,8 +242,8 @@ importers: specifier: ^8.6.12 version: 8.6.14(storybook@8.6.17(prettier@3.5.3)) '@storybook/addon-svelte-csf': - specifier: 5.0.0-next.28 - version: 5.0.0-next.28(@storybook/svelte@8.6.17(storybook@8.6.17(prettier@3.5.3))(svelte@5.36.13))(@sveltejs/vite-plugin-svelte@5.0.3(svelte@5.36.13)(vite@6.4.1(@types/node@22.19.13)(jiti@2.6.1)(sass@1.97.3)(tsx@4.19.3)(yaml@2.8.2)))(storybook@8.6.17(prettier@3.5.3))(svelte@5.36.13)(vite@6.4.1(@types/node@22.19.13)(jiti@2.6.1)(sass@1.97.3)(tsx@4.19.3)(yaml@2.8.2)) + specifier: 5.0.11 + version: 5.0.11(@storybook/svelte@8.6.17(storybook@8.6.17(prettier@3.5.3))(svelte@5.36.13))(@sveltejs/vite-plugin-svelte@5.0.3(svelte@5.36.13)(vite@6.4.1(@types/node@22.19.13)(jiti@2.6.1)(sass@1.97.3)(tsx@4.19.3)(yaml@2.8.2)))(storybook@8.6.17(prettier@3.5.3))(svelte@5.36.13)(vite@6.4.1(@types/node@22.19.13)(jiti@2.6.1)(sass@1.97.3)(tsx@4.19.3)(yaml@2.8.2)) '@storybook/blocks': specifier: ^8.6.12 version: 8.6.14(react-dom@18.3.1(react@18.3.1))(react@18.3.1)(storybook@8.6.17(prettier@3.5.3)) @@ -2398,14 +2398,14 @@ packages: peerDependencies: storybook: ^8.6.14 - '@storybook/addon-svelte-csf@5.0.0-next.28': - resolution: {integrity: sha512-Ojj6m8xEd3rlVP7PkNYv/0st4M0NZdSYWwnCowhsw3ItBasmyB8jmP5Ht2WmwH+EIUYq0mMfsRI7Rb6Yl63QbQ==} + '@storybook/addon-svelte-csf@5.0.11': + resolution: {integrity: sha512-grfiAAl0lsPph33NV/lJkDOC4JfrHYUacX0DuUA7/0vBcihlUaX1w7AMMZ9rMrhbCyeM1imz/2rp3FeOMb7EgQ==} peerDependencies: - '@storybook/svelte': ^0.0.0-0 || ^8.2.0 || ^9.0.0-0 - '@sveltejs/vite-plugin-svelte': ^4.0.0 || ^5.0.0 - storybook: ^0.0.0-0 || ^8.2.0 || ^9.0.0-0 + '@storybook/svelte': ^0.0.0-0 || ^8.2.0 || ^9.0.0 || ^9.1.0-0 || ^10.0.0-0 || ^10.1.0-0 || ^10.2.0-0 || ^10.3.0-0 + '@sveltejs/vite-plugin-svelte': ^4.0.0 || ^5.0.0 || ^6.0.0 + storybook: ^0.0.0-0 || ^8.2.0 || ^9.0.0 || ^9.1.0-0 || ^10.0.0-0 || ^10.1.0-0 || ^10.2.0-0 || ^10.3.0-0 svelte: ^5.0.0 - vite: ^5.0.0 || ^6.0.0 + vite: ^5.0.0 || ^6.0.0 || ^7.0.0 '@storybook/addon-toolbars@8.6.14': resolution: {integrity: sha512-W/wEXT8h3VyZTVfWK/84BAcjAxTdtRiAkT2KAN0nbSHxxB5KEM1MjKpKu2upyzzMa3EywITqbfy4dP6lpkVTwQ==} @@ -11177,7 +11177,7 @@ snapshots: storybook: 8.6.17(prettier@3.5.3) ts-dedent: 2.2.0 - '@storybook/addon-svelte-csf@5.0.0-next.28(@storybook/svelte@8.6.17(storybook@8.6.17(prettier@3.5.3))(svelte@5.36.13))(@sveltejs/vite-plugin-svelte@5.0.3(svelte@5.36.13)(vite@6.4.1(@types/node@22.19.13)(jiti@2.6.1)(sass@1.97.3)(tsx@4.19.3)(yaml@2.8.2)))(storybook@8.6.17(prettier@3.5.3))(svelte@5.36.13)(vite@6.4.1(@types/node@22.19.13)(jiti@2.6.1)(sass@1.97.3)(tsx@4.19.3)(yaml@2.8.2))': + '@storybook/addon-svelte-csf@5.0.11(@storybook/svelte@8.6.17(storybook@8.6.17(prettier@3.5.3))(svelte@5.36.13))(@sveltejs/vite-plugin-svelte@5.0.3(svelte@5.36.13)(vite@6.4.1(@types/node@22.19.13)(jiti@2.6.1)(sass@1.97.3)(tsx@4.19.3)(yaml@2.8.2)))(storybook@8.6.17(prettier@3.5.3))(svelte@5.36.13)(vite@6.4.1(@types/node@22.19.13)(jiti@2.6.1)(sass@1.97.3)(tsx@4.19.3)(yaml@2.8.2))': dependencies: '@storybook/csf': 0.1.13 '@storybook/svelte': 8.6.17(storybook@8.6.17(prettier@3.5.3))(svelte@5.36.13)